Implement Array#prepend and Array#append aliases#4934
Closed
ChrisBr wants to merge 1 commit intojruby:masterfrom
Closed
Implement Array#prepend and Array#append aliases#4934ChrisBr wants to merge 1 commit intojruby:masterfrom
ChrisBr wants to merge 1 commit intojruby:masterfrom
Conversation
to support Ruby 2.5, see https://bugs.ruby-lang.org/issues/12746. jruby#4876
Member
|
@ChrisBr master is for our upcoming Ruby 2.4 support. Could you submit this PR against the ruby-2.5 branch? |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to support Ruby 2.5, see https://bugs.ruby-lang.org/issues/12746.
#4876
It seems like tests already existed in
spec/ruby/core/array/append_spec.rbandspec/ruby/core/array/prepend_spec.rb