Skip to content

Set MetaClass of cloned object#4919

Merged
kares merged 1 commit intojruby:masterfrom
yui-knk:fix_test_clone
Jan 1, 2018
Merged

Set MetaClass of cloned object#4919
kares merged 1 commit intojruby:masterfrom
yui-knk:fix_test_clone

Conversation

@yui-knk
Copy link
Contributor

@yui-knk yui-knk commented Dec 30, 2017

In MRI, method_clone uses CLASS_OF method objects

clone = TypedData_Make_Struct(CLASS_OF(self), struct METHOD, &method_data_type, data);

By this change, TestMethod#test_clone will be passed.

In MRI, `method_clone` uses CLASS_OF method objects

```
clone = TypedData_Make_Struct(CLASS_OF(self), struct METHOD, &method_data_type, data);
```

By this change, `TestMethod#test_clone` will be passed.
@kares
Copy link
Member

kares commented Jan 1, 2018

Makes sense. Thanks Yui.

@kares kares merged commit 0a9dc53 into jruby:master Jan 1, 2018
@kares kares added this to the JRuby 9.2.0.0 milestone Jan 1, 2018
@kares kares added the core label Jan 1, 2018
@yui-knk yui-knk deleted the fix_test_clone branch January 1, 2018 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants