ThreadedNexter shutdown can in some situations interrupt a thread executing a different task#4887
Closed
jmalves wants to merge 1 commit intojruby:masterfrom
Closed
ThreadedNexter shutdown can in some situations interrupt a thread executing a different task#4887jmalves wants to merge 1 commit intojruby:masterfrom
jmalves wants to merge 1 commit intojruby:masterfrom
Conversation
Member
|
Very nice find! There have been lingering intermittent interrupted threads reported occasionally...this could have been the culprit. I'll have a look. |
headius
approved these changes
Dec 12, 2017
Member
|
It looks good, but I will merge manually to the 9.1 branch so it can be in 9.1.16. |
Member
|
Merged to 9.1 in 3011d3d. |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It can happen that the
ThreadedNexter#shutdownfrom RubyEnumerator sends interrupts to a thread that is executing a different task.ThreadedNexter#shutdowncan get the thread value before the Nexter thread is finished but send the interrupts after the Nexter thread is already done with its work. In case that the Nexter thread is already assigned another task those interrupts can cause problems.From what I could see it seems it affects all JRuby versions with
ThreadedNexter.To reproduce the issue:
Related to #2577 and #2824