Skip to content

Remove ant DSL/wrapper from stdlib and replace with gem.#4811

Merged
headius merged 4 commits intomasterfrom
remove-ant
Oct 10, 2017
Merged

Remove ant DSL/wrapper from stdlib and replace with gem.#4811
headius merged 4 commits intomasterfrom
remove-ant

Conversation

@headius
Copy link
Member

@headius headius commented Oct 10, 2017

This starts to address #2965. I have pulled the ant integration out of JRuby into a gem but it does not yet pull down Ant itself.

A few notes:

  • License is EPL 2
  • File structure has been updated to conform to namespacing norms (most stuff under rake/ant).
  • I had to include Rake::DSL into the toplevel of rake/ant/ant in order for bare calls to "tasks" and other top-level Rake DSL methods to work. There may be a cleaner way to make this work without polluting toplevel.
  • I'm not sure how best to pull down Ant. I assume it would be something in jar-dependencies but need help/advice from @mkristian here.

With the current pulled-out gem, we can build as normal and still run rake builds that (unfortunately) still depend on ant.

@headius headius merged commit 625fac9 into master Oct 10, 2017
@headius headius deleted the remove-ant branch October 10, 2017 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant