help classpath: canonicalization on Windows to fully resolve #4145#4647
Merged
headius merged 1 commit intojruby:masterfrom Jun 6, 2017
Merged
help classpath: canonicalization on Windows to fully resolve #4145#4647headius merged 1 commit intojruby:masterfrom
headius merged 1 commit intojruby:masterfrom
Conversation
has been attempted at cbf9a7d ... using a fake root path, however on Windows /SMT expands as C:\SMT added '__' at the end so its more obvious if this is slightly off again closes jruby#4630 (also jruby#4645)
headius
approved these changes
Jun 6, 2017
Member
headius
left a comment
headius
left a comment
There was a problem hiding this comment.
I have no strong opinion on the special path we use. I'll only mention that I included "JRUBY" in it to help localize it specifically to us. I seriously doubt anything will ever overlap the new prefix though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
has been attempted at cbf9a7d
... using a fake root path, however on Windows /SMT expands as C:\SMT
got a bit inspired by
C:/fakepathwhich browsers use but than I wasn't 100% sure@headius' previous
/THIS_IS_A_FAKE_PATH_FOR_JRUBYis probably a 'safer' bet ?added '__' at the end so its more obvious if this is slightly off again (
classpath:BY\pathwas confusing)closes #4630 (also #4645)