try harder to avoid long overflow in Time#+ (fixes #1779)#4646
Merged
headius merged 4 commits intojruby:masterfrom Jun 5, 2017
Merged
try harder to avoid long overflow in Time#+ (fixes #1779)#4646headius merged 4 commits intojruby:masterfrom
headius merged 4 commits intojruby:masterfrom
Conversation
Member
|
... very nice Stefan, could we have a test or spec please (as this is easy to break at some point) ? |
Contributor
Author
|
Added a small test (and reenabled some existing time related regression tests which pass) but i'm not sure if this is the best way to test. |
Member
|
@MSNexploder thanks, its not bad (you can leave it in) but does not actually test for the reported issue, ... would probably do, what do you think? |
Contributor
Author
|
@kares That was too easy 😎 Was focusing way to much on the underlying problem. |
Member
|
cool thanks a lot ... @headius could you double-check this is good to go for @MSNexploder, please? |
headius
approved these changes
Jun 5, 2017
Member
|
Looks good, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.