Skip to content

Fix Module inclusion order#4639

Merged
headius merged 3 commits intojruby:masterfrom
MSNexploder:module_order
Jun 6, 2017
Merged

Fix Module inclusion order#4639
headius merged 3 commits intojruby:masterfrom
MSNexploder:module_order

Conversation

@MSNexploder
Copy link
Contributor

This fixes Module inclusion order as seen in #1938

@headius
Copy link
Member

headius commented Jun 1, 2017

Failure appears to be directly related to the patch. Can you take a look into it?

@MSNexploder
Copy link
Contributor Author

Will look into it. Looks like the whole Module thing is not as straightforward as I hoped. 😉

@MSNexploder MSNexploder changed the title (re-)integrate pull request #2002 into JRuby 9k Fix Module inclusion order Jun 3, 2017
@MSNexploder
Copy link
Contributor Author

Pretty sure I got the Module#prepend working again 🎉

@headius
Copy link
Member

headius commented Jun 6, 2017

Well it passes tests...so I'll do a quick review and get it in! Thanks!

@headius headius merged commit d47687a into jruby:master Jun 6, 2017
@headius headius added this to the JRuby 9.1.11.0 milestone Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants