Fix Float::INFINITY BigDecimal comparison#4618
Merged
headius merged 1 commit intojruby:masterfrom Jun 5, 2017
cammellos:master
Merged
Fix Float::INFINITY BigDecimal comparison#4618headius merged 1 commit intojruby:masterfrom cammellos:master
headius merged 1 commit intojruby:masterfrom
cammellos:master
Conversation
Contributor
Author
|
The build seems ok on my branch, https://travis-ci.org/cammellos/jruby . The test failing seems to be unrelated to the commit, shoud I take a look at it or is ok? |
Member
|
@headius this seems to pass fine and isn't a big change, what do you think including the patch for 9.1 ? |
Member
|
double checked that this wasn't the behaviour in MRI 2.3.1 but the specs seems to match MRI (>=) 2.3.3 |
Member
|
@kares Seems appropriate to include it in 9.1.11. |
Member
|
Thanks for the fix and specs! |
Member
|
These specs do not pass on MRI 2.3.3 and 2.3.4: It looks like a MRI bug in 2.3.x. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
this fixes #4572
Any feedback would be appreciated
Thanks for the project!
andrea