Skip to content

Fix UDPSocket#(send|write) to raise EMSGSIZE#4608

Merged
kares merged 4 commits intojruby:masterfrom
etehtsea:4606-udp-emsgsize
May 24, 2017
Merged

Fix UDPSocket#(send|write) to raise EMSGSIZE#4608
kares merged 4 commits intojruby:masterfrom
etehtsea:4606-udp-emsgsize

Conversation

@etehtsea
Copy link
Contributor

@etehtsea etehtsea commented May 17, 2017

No description provided.

@etehtsea etehtsea force-pushed the 4606-udp-emsgsize branch from 7194af0 to 628beac Compare May 17, 2017 09:39
@etehtsea etehtsea force-pushed the 4606-udp-emsgsize branch from 628beac to d9c9137 Compare May 17, 2017 09:42
@kares
Copy link
Member

kares commented May 17, 2017

one failure on spec:ruby:fast seems legit?

     [exec] 1)
     [exec] UDPSocket#write raises EMSGSIZE if msg is too long ERROR
     [exec] NoMethodError: undefined method `closed?' for nil:NilClass
     [exec] Did you mean?  clone
     [exec] /home/travis/build/jruby/jruby/spec/ruby/library/socket/udpsocket/write_spec.rb:18:in `block in (root)'
     [exec] org/jruby/RubyBasicObject.java:1687:in `instance_eval'
     [exec] org/jruby/RubyEnumerable.java:1596:in `all?'
     [exec] org/jruby/RubyFixnum.java:299:in `times'
     [exec] org/jruby/RubyArray.java:1734:in `each'
     [exec] /home/travis/build/jruby/jruby/spec/ruby/library/socket/udpsocket/write_spec.rb:4:in `<main>'
     [exec] org/jruby/RubyKernel.java:979:in `load'
     [exec] org/jruby/RubyBasicObject.java:1687:in `instance_eval'
     [exec] org/jruby/RubyArray.java:1734:in `each'

@etehtsea
Copy link
Contributor Author

etehtsea commented May 17, 2017

Nope, I'll look into it.

@etehtsea etehtsea force-pushed the 4606-udp-emsgsize branch from d9c9137 to fec26b8 Compare May 17, 2017 12:27
@etehtsea etehtsea force-pushed the 4606-udp-emsgsize branch from fec26b8 to a84496c Compare May 17, 2017 15:17
@etehtsea
Copy link
Contributor Author

etehtsea commented May 18, 2017

@kares fixed (I hope).

@etehtsea etehtsea force-pushed the 4606-udp-emsgsize branch from a84496c to 571aa71 Compare May 18, 2017 03:36
@kares
Copy link
Member

kares commented May 18, 2017

👍 looks good to me ... not sure if we're to merge PRs yet since the 9.1.9.0 release is fairly recent

@kares kares added this to the JRuby 9.2.0.0 milestone May 24, 2017
@kares kares merged commit b04be74 into jruby:master May 24, 2017
@etehtsea etehtsea deleted the 4606-udp-emsgsize branch May 24, 2017 06:46
@dwbutler
Copy link

dwbutler commented May 31, 2017

If you're relying on the OS returning an error message of Message too long, you might have a bad time. It seems that Debian distributions return the error message Message too large. (See dwbutler/logstash-logger#128)

@etehtsea
Copy link
Contributor Author

etehtsea commented Jun 1, 2017 •
edited
Loading

@dwbutler according to this comment it look like Alpine specific issue.

Anyway it's possible to match both error messages.

P.S. I checked that it works properly on Debian Jessie.

@etehtsea etehtsea mentioned this pull request Jun 1, 2017
Merged
@headius headius modified the milestones: JRuby 9.1.11.0, JRuby 9.2.0.0 Jun 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

JRuby 9.1.11.0

Development

Successfully merging this pull request may close these issues.

4 participants

@etehtsea @kares @dwbutler @headius