Merged
Conversation
Contributor
Author
|
@ayappanec Is this patch ok to be merged for support for AArch64? |
|
The PR looks good. |
Contributor
Author
|
@headius Could you please check it? Thanks! |
olleolleolle
reviewed
Apr 5, 2017
| SPARCV9, | ||
| S390X, | ||
| ARM, | ||
| AARCH64, |
Member
There was a problem hiding this comment.
This is a tab, use spaces instead.
There was a problem hiding this comment.
Interesting !. How did you figured this out ? by seeing the indentation ?
Member
There was a problem hiding this comment.
The presentation was 1 character off in this view.
Then: Visiting "View", marking and dragging the cursor over and seeing that the visualization of the marked text "snapped" to a tab stop, not to individual spaces.
Contributor
|
@enebo Could you please take your time to review this changes? Thanks! |
Member
|
Hello! Sorry this slipped a bit. Looking into merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to add support for the AARCH64/ARM64 in JRuby FFI.