Use actual impl module to test bindability. Fixes #4477.#4521
Merged
headius merged 1 commit intojruby:masterfrom Mar 3, 2017
Merged
Use actual impl module to test bindability. Fixes #4477.#4521headius merged 1 commit intojruby:masterfrom
headius merged 1 commit intojruby:masterfrom
Conversation
Member
Author
|
Everything passed except for some newer flaky specs for Weakref. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #4477 by not using the origin module/class to test bindable hierarchy but instead using the actual implementation module. I'm not sure why it was doing the latter before, but it meant that any methods captured from a module were not bindable to class hierarchies that included that module (since the module was hidden behind a Prepended or IncludedModule origin).
This seems like the proper logic, but I'm doing it as a PR to check CI before pushing forward for 9.1.8.0.
There may be tests for this we don't pass but I could not find them.