Allow reads after calling BasicSocket#close_write.#4503
Merged
headius merged 1 commit intojruby:masterfrom Feb 24, 2017
Merged
Conversation
snowp
changed the title
Contributor
Author
|
looking at it again im thinking the |
Member
|
Ahh I had not seen you made a PR. Will review. |
Member
|
You're right, that line is redundant if the contract of shutdownInternal is to also update read/write flags. Seems like that's appropriate, since I can't imagine why we'd want it NOT to do so. I'll merge and remove the redundant line. |
|
@snowp THANKS! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shutdownInternalwas always shutting down the read side, even when we were trying to close the write side of the socket.Fixes #4500.