[ji] deterministic Java bean-style method aliases#4435
Merged
kares merged 2 commits intojruby:masterfrom Jan 17, 2017
Merged
Conversation
currently we're nondeterministic and depend on reflected method order foo -> getFoo method shall always win, since foo? is there for isFoo in case both getFoo and isFoo are specified the update should align nicely with expectations in jruby#3470 due compatibility we can not fix jruby#4432 isAnnotation() + getAnnotation(param) case is different since the get method isn't a (real) getter (and we're avoding a clash due jruby#3262)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
discovered during the investigation of #4432 (this addresses a different issue)
turns out the priority logic for setting up Java methods into Ruby land did not handle potential alias-ing conflicts for getters (same priority).
this test would periodically fail (more on travis-ci than locally always using the same JVM installation) ... JRuby already dealt with the non-determinstic case get/is issue before while generating wrappers: #3470
here we're making sure we always do the same setup for (unusual) cases with multiple getters for the same property e.g. getFoo() and isFoo() :
foois aliased togetFoo()(current state is that this is not always true and might point toisFoo())fooalias would point toisFoo()only if thegetFoo()is not present