Kill the LocalJumpError logic for break in lambda. Fixes #4369.#4423
Merged
enebo merged 1 commit intojruby:masterfrom Jan 11, 2017
Merged
Kill the LocalJumpError logic for break in lambda. Fixes #4369.#4423enebo merged 1 commit intojruby:masterfrom
enebo merged 1 commit intojruby:masterfrom
Conversation
Member
Author
|
I kicked the one job that failed, but this looks like it's ok. |
Contributor
|
If CI is happy and no one can actually come up with an error case, I suppose the existing semantics in JRuby is probably 1.8 or 1.9 and no longer relevant? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a complete removal of the error logic, but it did not fail the suites I ran locally. Open for comments or concerns @enebo @subbuss.