Remove unsafe-mock from our build altogether.#4381
Merged
headius merged 1 commit intojruby:masterfrom Dec 14, 2016
Merged
Conversation
headius
force-pushed
the
no-unsafe-mock
branch
from
81f43ef to
c6a95fb
Compare
Member
Author
|
@enebo Any objections? It does not add a dependency, but it is a new library (of one class) and it does get shaded in. I think it's worth it to eliminate the tweaky bootclasspath flags we've been passing. |
This commit replaces the unsafe-mock dependency -- which caused various build problems living in boot classpath -- with a new library that just shims the three Unsafe methods added in Java 8: fullFence, loadFence, and storeFence. This allows us to eliminate all calls to those methods from JRuby proper as well as the build tricks. Fixes jruby#4103.
headius
force-pushed
the
no-unsafe-mock
branch
from
c6a95fb to
64b9553
Compare
enebo
approved these changes
Dec 14, 2016
Member
enebo
left a comment
enebo
left a comment
There was a problem hiding this comment.
looks good to me...now I can also use debug in intellij without commenting out 3 lines!!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit replaces the unsafe-mock dependency -- which caused
various build problems living in boot classpath -- with a new
library that just shims the three Unsafe methods added in Java 8:
fullFence, loadFence, and storeFence. This allows us to eliminate
all calls to those methods from JRuby proper as well as the build
tricks.
Fixes #4103.