Fix unexpected java.lang.ArithmeticException when converting Rational to BigDecimal#4336
Conversation
when converting Rational to BigDecimal Fixes jruby#4324
|
(Totally unrelated to your fix:) The appveyor CI job failed with this message: https://ci.appveyor.com/project/jnr/jruby/build/2880/job/shniu1cn7yluu99o#L1692 Hm, perhaps |
|
@olleolleolle I think that the I'm more worried about other failures like |
|
@kirs najs fix ... although it looks a bit scary on first sight :) |
|
@kares if you reviewed this and are happy with it you can merge it. I felt out of depth on this one. |
I'm not sure that
catch (ArithmeticException e)is the best way to fix it, but at least this would emulate MRI behaviour (read #4324 for more context)Fixes #4324
@enebo @headius