fix Array#sum and Enumerable#sum#4309
Merged
headius merged 4 commits intojruby:ruby-2.4from Nov 17, 2016
phluid61:feature/optimise-enumerable-sum
Merged
fix Array#sum and Enumerable#sum#4309headius merged 4 commits intojruby:ruby-2.4from phluid61:feature/optimise-enumerable-sum
headius merged 4 commits intojruby:ruby-2.4from
phluid61:feature/optimise-enumerable-sum
Conversation
Contributor
Author
|
I'm not entirely comfortable that RubyArray is now an expert on Fixnum, Bignum, Rational and Float, but the behaviour matches MRI's. |
Member
|
Looks good! Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes
Array#sumandEnumerable#sumto use Kahan's compensated summation algorithm, so we have the same rounding artifacts as MRI.It also includes some of the MRI's cascading coercion behaviour in
Array#sumNow all tests in
test/mri/ruby/test_array.rbandtest/mri/ruby/test_enum.rbpass, except for those depending on 'mathn' which I can't test because of an unrelated issue.Consider this a regression fix for #4297