Conversation
Member
|
@kcdragon Logic was right on. My only comment for next one is to try and use a full name like filename and not f. We have some other brace logic which is like 95% followed so that might be another style tweak suggestion in the future. Congratulations you are the on JRuby commit board. The tracks have been greased...onward! :) |
Member
|
@kcdragon There are some examples of running individual test files from the MRI suite in BUILDING.md. Basically, the test/mri/runner.rb script can be used to set up appropriate paths and such, and there's a feature in there that's used to exclude tests known to fail (for maintaining a high-water mark). Perhaps we should have a better page in the wiki for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the class methods
File.empty?(andFile.zero?). I includedFile.zero?becauseFile.empty?in the docs links toFile.zero?. https://ruby-doc.org/core-2.4.0_preview3/File.html#method-c-empty-3F (I'm guessing one is an alias of the other)See #4293 where feature is originally mentioned.
This PR gets the test
test_empty_pin "test/mri/ruby/test_file_exhaustive.rb" to pass. I figured that I didn't need to add any other tests since this functionality is tested by the MRI tests. Let me know if I do need to add more tests.I did run into an issue while testing with just that file. If I ran just this command
I get an error about missing
assert_file.I needed to add
require_relative 'envutil'(which addsassert_file) in order to run the tests. I would have included that change in this PR but it looks like those tests are generated based on the tests in Ruby and I wasn't sure if changes to those files would be overridden when new tests are brought in. That file is probably eventually required when the whole suite is run.This is my first time contributing to JRuby so let me know if there is something missing that I need to include.