Implement Socket.socketpair to return Socket instances#4204
Merged
headius merged 5 commits intojruby:masterfrom Oct 5, 2016
Merged
Implement Socket.socketpair to return Socket instances#4204headius merged 5 commits intojruby:masterfrom
headius merged 5 commits intojruby:masterfrom
Conversation
headius
reviewed
Oct 5, 2016
|
|
||
| s1.should be_an_instance_of(Socket) | ||
| s2.should be_an_instance_of(Socket) | ||
| end |
Member
Member
There was a problem hiding this comment.
It's OK to add specs directly here, even if the commits contains other changes. The advantages is it's tested directly against jruby and we don't need to wait for a spec merge.
However I prefer if the specs are in a commit alone as usually it means I don't need to edit the commit message 😃
eregon
reviewed
Oct 5, 2016
| s1, s2 = Socket.public_send(@method, :UNIX, :STREAM) | ||
|
|
||
| s1.should be_an_instance_of(Socket) | ||
| s2.should be_an_instance_of(Socket) |
Member
There was a problem hiding this comment.
The opened file descriptors should be closed here.
etehtsea
force-pushed
the
socket-socketpair
branch
2 times, most recently
from
b0fffa7 to
88f82fd
Compare
etehtsea
force-pushed
the
socket-socketpair
branch
from
88f82fd to
354b35b
Compare
Contributor
Author
|
Done. |
sock2 was left uninitialized
etehtsea
force-pushed
the
socket-socketpair
branch
from
354b35b to
303e5d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.