Bring BigMath::log behaviour closer to MRI#4170
Closed
shirshendu wants to merge 1 commit intojruby:masterfrom
Closed
Bring BigMath::log behaviour closer to MRI#4170shirshendu wants to merge 1 commit intojruby:masterfrom
shirshendu wants to merge 1 commit intojruby:masterfrom
Conversation
Especially for a Rational, high precision use-case Fixes jruby#4158
Contributor
Author
|
Just for convenience, the command for running the newly added test case: |
headius
reviewed
Sep 22, 2016
| r = Rational(1_234_567_890, 987_654_321) | ||
| assert_in_delta(result, BigMath.log(r, 50), 0.0000000000_0000000000_0000000000_0000000000_0000000001) | ||
| end | ||
|
|
Member
There was a problem hiding this comment.
We don't usually edit the MRI tests since there's no good process for upstreaming those changes. I'll move this to spec/ruby.
headius
added a commit
that referenced
this pull request
Sep 22, 2016
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Especially for a Rational, high precision use-case
Fixes #4158