Merged
Conversation
Member
|
+1 for the commit @jellymann could you remove all those maven-metadata-local.xml files. I have seen them creeping in before but do not have an idea how this happens. |
Contributor
Author
|
@mkristian Sorry about that. I saw them get created and meant to make sure not to commit them, but I must have forgotten. They seem to have been created the first time I ran |
Member
|
yes, I just saw them too on jruby-readline after the first run of maven. at
least some clue to start digging :)
|
Member
|
@headius for me this is good to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue exposed by #3901.
Extension of #3902 for 9k, with tests and an
isDirectorycheck (canReadreturns true for directories, but then throws when callinginputStream)I'm not sure about testing
CONon Windows. I have only tested on macOS so far.These tests (and isDirectory change) would also need to backported to the 1.7 branch
CC @mkristian and @headius