Extra tests for symbol encoding Re: #4070 + #3719 and possibly #3880#4096
Merged
kares merged 1 commit intojruby:masterfrom Jan 10, 2018
Merged
Conversation
Contributor
Author
|
More than happy to close this in lieu of #4099 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saw this tweet https://twitter.com/headius/status/766771177301774337
So I decided to write a few simple failing tests isolating issues issues discussed in #4070 and #3719. This could also overlap with #3880 so I figured I would mention that too.
Very happy to rename specs since I'm bad at naming them or committing these into ruby/spec if that is appropriate. I just put them here because of similar specs relating to #2896.