Merged
Conversation
| ProtocolFamily family = SocketUtils.protocolFamilyFromArg(args[0]); | ||
| SocketLevel level = RubyBasicSocket.levelFromArg(args[1]); | ||
| SocketOption option = RubyBasicSocket.optionFromArg(args[2]); | ||
| int intData = args[3].isTrue() ? 1 : 0; |
Contributor
Author
There was a problem hiding this comment.
Should it be checked there that it actually a boolean arg and what to do in case if it's not?
- Fix Socket::Option.int - Fix Socket::Option.bool - Fix Socket::Option#bool
Fix socket initialization with type passed as a string (for ex. 'SOCK_STREAM')
etehtsea
force-pushed
the
socket-options
branch
from
c953ae9 to
6f143cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specs passed, so, hopefully, it should work.
P.S. Also I wanted to fix
Socket.linger, but it requires more substantial changes and I put it aside for a while.Disclaimer:
I will be happy to see some feedback how it could be improved.