Skip to content

Use Java's Arrays.sort#3961

Merged
enebo merged 2 commits intojruby:masterfrom
sri:use-java-native-sort
Jun 15, 2016
Merged

Use Java's Arrays.sort#3961
enebo merged 2 commits intojruby:masterfrom
sri:use-java-native-sort

Conversation

@sri
Copy link
Contributor

@sri sri commented Jun 9, 2016

Java's Arrays.sort more robust and is faster is certain cases.

See #3919 and
https://github.com/sri/jruby-sort-benchmark.

Java's Arrays.sort more robust and is faster is certain cases.

See jruby#3919 and
https://github.com/sri/jruby-sort-benchmark.
@enebo
Copy link
Member

enebo commented Jun 14, 2016

@sri could you re-add the util class and @deprecate it at the top. I do not know if extensions use that class or not but it is public.

@sri
Copy link
Contributor Author

sri commented Jun 15, 2016

@enebo Done!

@enebo enebo merged commit f434a33 into jruby:master Jun 15, 2016
@enebo
Copy link
Member

enebo commented Jun 15, 2016

@sri thanks for the PR and the time taken to show Java's sort has improved!

@sri
Copy link
Contributor Author

sri commented Jun 16, 2016

@enebo Great! Thanks for all the pointers!!

@enebo enebo added this to the JRuby 9.1.3.0 milestone Aug 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants