Skip to content

Windows symlink#3926

Merged
headius merged 1 commit intojruby:masterfrom
headius:windows_symlink
May 25, 2016
Merged

Windows symlink#3926
headius merged 1 commit intojruby:masterfrom
headius:windows_symlink

Conversation

@headius
Copy link
Member

@headius headius commented May 25, 2016

This incorporates symlink support from @djberg96's win32-file and ffi-win32-extensions projects.

@djberg96 Ideally we'd just include this in JRuby under our tri-license (EPL, GPL2, LGPL2). If that's ok with you, let us know you consent to your code being licensed that way.

This seems to be everything I need, but when I try to install warbler (this is intended to fix #3905) I get this peculiar error:

λ gem install warbler
ERROR:  While executing gem ... (SystemCallError)
    Unknown error 1314 - CreateSymbolicLink

So this isn't quite ready yet.

@headius headius added this to the JRuby 9.1.2.0 milestone May 25, 2016
@headius headius force-pushed the windows_symlink branch from 1842a6a to 9f75a9a Compare May 25, 2016 16:10
@headius headius mentioned this pull request May 25, 2016
Closed
@headius
Copy link
Member Author

headius commented May 25, 2016

Ahh, seems like this may be a permission issue on Windows 7: http://stackoverflow.com/questions/26020777/createsymboliclink-runs-on-windows-8-returns-error-code-1314-on-windows-7

Maybe it's time for me to update my Windows to 10, but I think you want this to work on Windows 7 too, right @djberg96?

@djberg96
Copy link
Contributor

djberg96 commented May 25, 2016

@headius Yeah, we don't try to elevate privileges, users would have to install with administrator rights.

I'm not sure if we want to do that, but you certainly could. And you definitely have permission to copy/paste whatever you need.

I still don't understand this rake version error, though.

@headius
Copy link
Member Author

headius commented May 25, 2016

Yeah I'm not sure about that error either. I'll see if I can reproduce it.

@headius headius force-pushed the windows_symlink branch from 9f75a9a to 48bcc37 Compare May 25, 2016 17:49
headius added a commit to headius/jruby that referenced this pull request May 25, 2016
@headius
Borrow code from djberg96/win32-file for symlink support.
48bcc37 
Permission given to relicense in JRuby by @djberg96 at
jruby#3926 (comment)
@headius
Copy link
Member Author

headius commented May 25, 2016

Will merge after we have a clean travis run.

@headius headius force-pushed the windows_symlink branch from 48bcc37 to 3d1ada0 Compare May 25, 2016 20:51
@headius
Copy link
Member Author

headius commented May 25, 2016

Rebase to master will be clean, so I'm merging now.

@headius headius merged commit 07313c1 into jruby:master May 25, 2016
@headius headius deleted the windows_symlink branch May 25, 2016 20:53
enebo pushed a commit that referenced this pull request May 26, 2016
@headius @enebo
Borrow code from djberg96/win32-file for symlink support.
1a69b11 
Permission given to relicense in JRuby by @djberg96 at
#3926 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

core ffi ruby 2.3 windows

Projects

None yet

Milestone

JRuby 9.1.2.0

Development

Successfully merging this pull request may close these issues.

NotImplementedError: symlink unsupported or native support failed to load

2 participants

@headius @djberg96