Soften this restriction to just readable resources.#3902
Merged
headius merged 1 commit intojruby:jruby-1_7from May 26, 2016
Merged
Soften this restriction to just readable resources.#3902headius merged 1 commit intojruby:jruby-1_7from
headius merged 1 commit intojruby:jruby-1_7from
Conversation
Additional fix for issue exposed by jruby#3901. Devices, like ttys, pipes, fifos and the like may be neither file nor symlink, but still readable as script source. The restriction here is unnecessary.
Member
|
@headius looks ok to me. do not remember the details, but was something like a directory path as resource. |
Contributor
|
@headius @mkristian I have tested with a directory, it passes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional fix for issue exposed by #3901. Devices, like ttys,
pipes, fifos and the like may be neither file nor symlink, but
still readable as script source. The restriction here is
unnecessary.
Ping @mkristian... I softened this test but I'm not sure why it was so restrictive in the first place. Is this change ok?