Fix a bug where NameError#receiver raises an ArgumentError after #to_s is called#3832
Merged
headius merged 1 commit intojruby:masterfrom Apr 27, 2016
yuki24:fix-nameerror-receiver
Merged
Fix a bug where NameError#receiver raises an ArgumentError after #to_s is called#3832headius merged 1 commit intojruby:masterfrom yuki24:fix-nameerror-receiver
headius merged 1 commit intojruby:masterfrom
yuki24:fix-nameerror-receiver
Conversation
…s is called If the `NameError#to_s` is called before `NameError#receiver` is called, the NameError object will lose the source of the receiver object (https://github.com/jruby/jruby/blob/b856557/core/src/main/java/org/jruby/RubyNameError.java#L223) and the `NameError#receiver` method will raise an ArgumentError when it shouldn't. error = (1.foo rescue $!) error.receiver # => 1 error.to_s # => NameError: ... <= This call replaces the `message` object error.receiver # => ArgumentError: no receiver is available This commit changes the initializer to retrieve the receiver object so that the behavior of the method will be consistent.
Member
|
Nice find, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the
NameError#to_sis called beforeNameError#receiveris called, the NameError object will lose the source of the receiver object and theNameError#receivermethod will raise an ArgumentError when it shouldn't:This commit changes the initializer to retrieve the receiver object so that the behavior of the method will be consistent.