Enable AppVeyor tests on 64-bit Java on Windows as well.#3774
Enable AppVeyor tests on 64-bit Java on Windows as well.#3774perlun wants to merge 1 commit intojruby:jruby-1_7from
Conversation
It was already enabled on the master branch, but not here. Side note: Should we also add the ant MRI tests on master? I noted that it was only enabled in the jruby-1_7 branch, but not in the appveyor.yml on master.
perlun
changed the title
|
@perlun 64 bit is currently disabled because our current native launcher only can in-process launch the JVM in 32 bit mores. In 64 JVM it fails and the launcher falls back to launching Java via the command-line. We have an open bug on windows (I don't recall number offhand) which covers the fact that we improperly quote in the native launcher in the presence of quotes. This causes many tests to fail which invoke sub-procs of JRuby. We also have no ability to skip tests based on VM arch type (32 v 64) so I disabled running on 64 bit JVMs until we upgrade mjruby into jruby-launcher project. Whew...a lot of explanation for why I am not merging this today :) It will be added in once we update jruby-launcher. |
Hehe, ok! Thanks for taking the time to explain the "why's" behind this. |
2 participants
It was already enabled on the master branch, but not here.
Side note: Should we also add the ant MRI tests on master? I noted that it was only enabled in the jruby-1_7 branch, but not in the appveyor.yml on master.
(@enebo - I happened to see this after your comment in #3767)