Conversation
…e building - add getMessageAsJavaString to potentially avoid String -> RubyString -> String - deprecated direct RubyException.message (unfortunately public) field access - protected RubyException allows a null message to be handled by sub-classes
Member
|
👍 This stuff is all old and should be removed whenever we see it. We have completely different notions of how exceptions work now, and NativeException is not a part of it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wasn't able to find a test/spec or a reason why
RaiseExceptiondid (forNativeException) :9.1 sounds like a good place to break away from that message building - which would actually only be seen very rarely (effectively almost never without hacks) even without the patch as
RaiseExceptiondoes re-set theprovidedMessagefield in case of theNativeExceptionconstructor path.another annoyance with
NativeExceptionis thecause.stackTrace + backtracejoin-ing - which shouldn't be necessary at all ... for now I've kept it for cases where the trace heads do not point to the same location. that means 99% cases it won't show up. except when the head would be filtered away as a JRuby internal. there seem to have been some specialNativeExceptionfiltering in place previously but with filtering going on elsewhere I did not want to filter twice esp as it seemed unnecessary.tests on Java as well as Ruby side to cover functionality.
p.s.
RubyExceptiongot agetMessageAsJavaString(would love to have been able to just changegetMessageto returnString:) which is used byRaiseException- this way at least forNativeExceptionthe String -> RubyString -> String message conversion can be avoided 🎉