Skip to content

Quick change to add support for jruby on msys/mingw#37

Closed
jasonkarns wants to merge 1 commit intojruby:masterfrom
jasonkarns:master
Closed

Quick change to add support for jruby on msys/mingw#37
jasonkarns wants to merge 1 commit intojruby:masterfrom
jasonkarns:master

Conversation

@jasonkarns
Copy link
Contributor

This change simply executes the jruby.exe (passing along any arguments) when 'jruby' is called from mingw. It then exits with the returned code from jruby.exe.

@jstoneham
Copy link

I was about to create a pull request that made things work under Git Bash (MSysGit) that allowed you to specify JRUBY_HOME outside the script so you wouldn't have to worry about c:\whatever vs. /c/whatever rewriting issues. This looks like it might resolve the situation in a more general way. Do you think so?

@jasonkarns
Copy link
Contributor Author

I can't be sure, but I don't think that will solve the issue. MinGW is already looking in the correct location, it's just using the wrong executable. The problem is that MinGW sees the jruby shell script and tries to execute that first, which doesn't work from MinGW. On Windows, jruby.exe is what ought to be executed. The simplest solution is to simply delete the jruby shell script. My change accomplishes virtually the same thing, by quickly executing jruby.exe from the jruby shell script.

@BanzaiMan
Copy link
Member

This seems OK to pull, but for some reason Github won't let me. ("This pull request can not be automatically merged.")

Can you open a ticket at http://bugs.jruby.org and attach a git patch there?

@jasonkarns
Copy link
Contributor Author

I created a new branch (mingw) and rebased from master in order to make a clean merge. New pull request from mingw branch here: #42

@jasonkarns
Copy link
Contributor Author

This pull request was duplicated by pull #42 which was successfully merged into master and closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants