Conversation
Member
|
great, was hoping to have it on jruby-1_7 but I guess it won't work in --1.8 ;( mode ... thus 9K it is! |
Member
|
changing |
benlovell
force-pushed
the
rspec-3
branch
2 times, most recently
from
6f54606 to
a79a887
Compare
Contributor
Author
|
Of course now having upgraded to RSpec 3 there are other failures. I'll get those sorted now - they seem to be mostly around the |
benlovell
force-pushed
the
rspec-3
branch
2 times, most recently
from
1bf0d71 to
46b8340
Compare
Contributor
Author
|
It seems those outstanding CI issues are unrelated to my changes, so I think this is good to go otherwise. I'll squish it down to something sensible when I get the OK. |
Contributor
Author
|
@kares thanks for reviewing 😍 Those issues should be addressed now. |
Member
Mostly simple syntax changes to the new `expect` style but also various manual fixes where transpec didn't quite do the job. Normally around the new `pending` semantics, and that the block form of `pending` is deprecated. Another big one was being explicit about the types of errors thrown. There is still plenty of room for improvement here but at least we are up and running on the latest/greatest RSpec vintage.
Contributor
Author
|
@kares I rebased and squashed into one logical commit. 🚢 |
😍
Member
|
the spec ci run finished green so no need to wait for osgi++ to finish....thanks @benlovell this is massive! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates JI integration specs to RSpec 3 syntax. This was performed mostly via
transpecbut did require a modicum of manual fixups. Some of the key gotchas were around the semantics ofpendingandskip- especially the block form ofpendingwhich has since been deprecated. Theraise_errormatcher now requires an explicit error to reduce false-positives.I made a few other minor cleanups and there were some flat-out broken specs that were fixed too.
There is still plenty of room for improvement in the tests that I'll be happy to soldier on with.
The history isn't the cleanest so I'll squash this down to something sane once it's green but it should be good to go otherwise. ❤️