add to_h to the class used for ENV#3218
Conversation
f270b34 to
4fad5de
Compare
|
change seem to introduce a failure e.g. here https://travis-ci.org/jruby/jruby/jobs/73959532#L3277-L3284 |
|
@kares So it does. Doesn't happen on oraclejdk8, so installing openjdk7 to see if I can reproduce there. |
|
hi @kares - just found the issue and committed a fix. |
|
since this is rubyspecs your updating it needs a certain level of quality, you seem to set we also need the spec change to be in separate commits (so it can be easy ported upstream), thus please update your commits to be clean (one fixinig |
1014fd0 to
f1b442d
Compare
f1b442d to
cbd7296
Compare
|
Hi @kares, that's done. Thanks! |
|
@reuben-sutton excellent, thanks! this should be good to go - we're just wait to hear about travis-ci (no worries about unrelated failures) |
add to_h to the class used for ENV
That makes it so that it duplicates rather than returning the same object to make compatible with MRI
fixes #3162