Conversation
|
@ahorek seems good but without a test is a little less worthy, any chance you do a test-case or tell us what use-case (sample .rb script) has been failing for you that the change fixes? thanks |
|
@kares - hi, most jruby tests don't work on windows and this is windows specific. Failing scenario is already described in the related issue. => for windows it should look something like this: |
|
seems good ... @mkristian what do you think of: |
|
the usual java vs. ruby paths. yes, this is OK. still a test which passes on windows as on unix would be great. one there we will have a CI running on windows and then it is important that we have a good test coverage for those windows only cases. test/jruby/test_file.rb is also a good place for such a test as this is in jruby direct control. |
|
@mkristian thanks I wasn't sure since its been a while when a tried JRuby on Windows. |
02bd228 to
6b947e0
Compare
6b947e0 to
c39825f
Compare
|
@kares - I've added very simple cases, is it ok? this fix should be also backported to JRuby 1.7.23 |
|
@ahorek looks good, we're in the process of merging jruby-1_7 into master, |
fixes #3132