Fix date.rewrite_frags#3119
Closed
skmp wants to merge 1 commit intojruby:masterfrom
skmp:fix/date-rewrite-frags-#2149
Closed
Fix date.rewrite_frags#3119skmp wants to merge 1 commit intojruby:masterfrom skmp:fix/date-rewrite-frags-#2149
skmp wants to merge 1 commit intojruby:masterfrom
skmp:fix/date-rewrite-frags-#2149
Conversation
According to MRI, offset should be preserved and added to the seconds. Fixes #2149
Member
|
your commit landed on master as: a0b6eda ... thanks for back-porting this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to MRI, offset should be preserved and
added to the seconds.
Fixes #2149
For reference, https://github.com/ruby/ruby/blob/39051ba1b94c61e92f333e514982c8f1333c7223/ext/date/date_core.c#L3682.
DateTime.strptime ignored timezone offsets when initialized via seconds, which is the cause of the test fail on #2149. If offset is dropped, the timezone information is lost.