isOpen()/close() is racy. Simply close and ignore EBADF.#3093
Closed
eam wants to merge 1 commit intojruby:jruby-1_7from
Closed
isOpen()/close() is racy. Simply close and ignore EBADF.#3093eam wants to merge 1 commit intojruby:jruby-1_7from
eam wants to merge 1 commit intojruby:jruby-1_7from
Conversation
Contributor
Author
|
This fixes a race which can be hit within a few thousand iterations of: loop do |i|
IO.popen4('echo', 'hi') { |_, _, out, _| out.read }
endI believe the descriptor is occasionally closed between the test of isOpen() and the close(), triggering the exception. |
Member
|
I might feel better if we did both, actually, to avoid unnecessarily raising an error that gets ignored. The failed race would then be the only case that raises. |
headius
added a commit
that referenced
this pull request
Jul 2, 2015
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.