[#2867] modified Date#>> to take calendar reforms under consideration#3091
Closed
ransoca wants to merge 6 commits intojruby:masterfrom
Closed
[#2867] modified Date#>> to take calendar reforms under consideration#3091ransoca wants to merge 6 commits intojruby:masterfrom
ransoca wants to merge 6 commits intojruby:masterfrom
Conversation
ransoca
commented
Jun 29, 2015
- added tests for next month with calendar reform
- uses solution provided in Inconsistency with MRI when adding a month to a date near Date::ITALY #1769 comments
- also fixes issues Inconsistency with MRI when adding a month to a date near Date::ITALY #1769
…ation - added tests for next month with calendar reform - uses solution provided in jruby#1769 comments - also fixes issues jruby#1769
Member
Member
|
These tests would be useful in RubySpec. You can just do a separate commit touching Well, if this behavior must be supported, I'd say there is not much choice. |
Author
|
I'll move test cases from |
Member
|
The changes look ok to me but I defer to @eregon on when and whether this should merge. |
Member
|
@raeoks Could you move the test cases to specs? Or should I do it? |
Author
|
@eregon I'll do it and doing it right now. |
added 5 commits
July 8, 2015 16:07
Author
Member
Member
|
optimally, there would be only one PR targeting jruby-1_7 (branch is periodically merged to master) ... |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.