Don't warn on private attribute accessors to match CRuby#3002
Closed
gsamokovarov wants to merge 1 commit intojruby:masterfrom
Closed
Don't warn on private attribute accessors to match CRuby#3002gsamokovarov wants to merge 1 commit intojruby:masterfrom
gsamokovarov wants to merge 1 commit intojruby:masterfrom
Conversation
I'm sorry for the back and forth on this one. I introduced it back in jruby#2637, but CRuby have recently removed the warning in https://bugs.ruby-lang.org/issues/10967.
Member
|
for reference it's the same one as ruby/ruby#849 under MRI |
Member
Contributor
Author
|
💜 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm sorry for the back and forth on this one. I introduced it back in
#2637, but CRuby have recently removed the warning in
https://bugs.ruby-lang.org/issues/10967.