Support respond_to_missing? in respondsTo() lookups#2797
Merged
enebo merged 2 commits intojruby:masterfrom Apr 6, 2015
Merged
Conversation
RubyBasicObject assumes that if respond_to? is undefined, it can just fast-track method lookups. We have to also check for respond_to_missing?; failure to do so causes Javaland respondsTo() calls to fail when an object defines respond_to_missing? (despite the documentation's admonishment to not use it) The practical case for this is ActiveSupport::Duration in ActiveSupport 4.2.1
Member
|
@cheald close but it triggered at least one error: 2 jobs failed so you should review that other job as well. |
Contributor
Author
|
Whoops. I shouldn't commit when tired. Fixing up. |
…o/respond_to_missing
enebo
added a commit
that referenced
this pull request
Apr 6, 2015
Support respond_to_missing? in respondsTo() lookups
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RubyBasicObject assumes that if respond_to? is undefined, it can just fast-track
method lookups. We have to also check for respond_to_missing?; failure to do so causes
Javaland respondsTo() calls to fail when an object defines respond_to_missing? (despite
the documentation's admonishment to not use it)
The practical case for this is ActiveSupport::Duration in ActiveSupport 4.2.1