Allow File.open and File.new with 4 arguments#2756
Merged
enebo merged 1 commit intojruby:masterfrom May 2, 2015
Merged
Conversation
Contributor
Author
|
Ok, not quite then. I'll take a look at it again. |
Member
|
@lumeet This removed convertToHash which will try and call to_hash if it is not an explicit Ruby Hash. I think perhaps tests are working but I think this will now break: class Foo; def to_hash; {cr_newline: true }; end; end
File.open('test', 'w', 0777, Foo.new) { |f| f.puts 'test' } |
The methods now support filename, mode, permissions and options as separate parameters.
Contributor
Author
|
@enebo It should be better now. Hopefully I haven't forgotten anything. |
enebo
added a commit
that referenced
this pull request
May 2, 2015
Allow File.open and File.new with 4 arguments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The methods now support filename, mode, permissions and options as
separate parameters.
The actual logic seems to be there already. For example, the following now has the same behavior as MRI 1.9+.