Socket.getaddrinfo reverse_lookup#2724
Conversation
|
This looks good. Maybe we can modify it to use boolean instead of Boolean and just have a separate method with no boolean parameter for the "null" behavior you have now? |
|
I'm not quite sure how to completely get rid of the Boolean, since the current code relies on the If the concern is over having the |
|
I noticed I've made a serious error in doing a String comparison using the == operator in my initial Pull Request. I'm new to the Git paradigm; is the proper procedure here to make a brand new Pull Request, with the fixed code and close this one? |
|
Just amend your fix to your existing commit and do a force push to your socket_getaddrinfo_reverse_lookup branch and it will update on this pull request. |
Adding reverse_lookup parameter support to Socket.getaddrinfo. This parameter was added in Ruby 1.9.
999a7ac to
d0cec55
Compare
|
Amending and force pushing worked like a charm, thanks. |
Socket.getaddrinfo reverse_lookup
Socket.getaddrinfo reverse_lookup
Added the reverse_lookup parameter to Socket.getaddrinfo. This was added in Ruby 1.9.