Fix File.read with UTF-16LE by lumeet · Pull Request #2605 · jruby/jruby

lumeet · 2015-02-17T18:59:03Z

File.open("a.txt", "w+") do |f|
  f.write "\xFF\xFE"
  f.close
end
File.read("a.txt", mode: "rb:bom|utf-8")

...results in...

<java.lang.ClassCastException: org.jruby.RubyNil cannot be cast to org.jruby.RubyFixnum>

A check for a null value seems to be missing after the BOM.

The test_truncate_wbuf removal is just general cleanup. It doesn't have anything to do with the fix. I guess it's ok. :)

A null value after the BOM no longer causes an error.

enebo · 2015-05-01T17:15:49Z

@lumeet Sorry for leaving this so long but it no longer applies cleanly. Can you update this PR?

lumeet · 2015-05-01T19:03:51Z

@enebo I'm closing this. The bug is fixed by another commit and test/mri/excludes/TestFile.rb looks the same on master, too.

Fix File.read with UTF-16LE

36b929a

A null value after the BOM no longer causes an error.

enebo added this to the JRuby 9.0.0.0.rc1 milestone May 1, 2015

enebo added the core label May 1, 2015

lumeet closed this May 1, 2015

lumeet deleted the file_bom_16le branch May 1, 2015 19:04

Provide feedback