Add support for named captures in StringScanner (fixes #1067)#2603
Closed
MSNexploder wants to merge 1 commit intojruby:masterfrom
Closed
Add support for named captures in StringScanner (fixes #1067)#2603MSNexploder wants to merge 1 commit intojruby:masterfrom
MSNexploder wants to merge 1 commit intojruby:masterfrom
Conversation
Contributor
Author
|
Actually this is my very first pull request for JRuby so...
|
Member
|
@MSNexploder ah yeah assert error is because you need to run with test/mri/runner.rb: |
Member
|
@MSNexploder Sorry we left this so long...can you rebase this it no longer applies cleanly... |
Contributor
Author
Member
|
@MSNexploder great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_AREF should pass but fails locally with "undefined method `assert_raise_with_message'" and i'm not sure why. 😓