Make filepaths with null byte fail#2583
Merged
enebo merged 1 commit intojruby:masterfrom Feb 11, 2015
Merged
Conversation
This patch applies to several methods that deal with filepaths in Dir, File, File::Stat, IO, and Kernel. All of these methods now raise an argument error if a null byte is detected in a path argument. Some of these methods are also slightly refactored, mostly by replacing context.runtime with just runtime where applicable.
enebo
added a commit
that referenced
this pull request
Feb 11, 2015
Make filepaths with null byte fail
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch applies to several methods that deal with filepaths in Dir,
File, File::Stat, IO, and Kernel. All of these methods now raise an
argument error if a null byte is detected in a path argument.
Some of these methods are also slightly refactored, mostly by replacing
context.runtimewith justruntimewhere applicable.MRI uses
StringValueCstrextensively for this purpose. In JRubyStringSupport.checkEmbeddedNullsseems to do the same job unless I've missed something.After http://jira.codehaus.org/browse/JRUBY-4828, at least File.read raised a SecurityError with the same message but the current 1.7 branch doesn't seem to have any of these checks.