Implemented Enumerator#feed method#2486
Merged
enebo merged 3 commits intojruby:masterfrom Jan 22, 2015
Merged
Conversation
Member
|
A few improvements you should do:
|
Member
|
And I said this in other PR about no curlies on single line ifs. So since there are other things to change do that as well. |
Contributor
Author
|
Made the changes based on the feedback. |
enebo
added a commit
that referenced
this pull request
Jan 22, 2015
Implemented Enumerator#feed method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements Enumerator#feed and addresses #1571. However the behaviour is not same as MRI because of the difference in implementation of next in JRuby and MRI.
Here is an example to demonstrate the difference,
MRI
JRuby
So basically when you call next first time in MRI, it actually initialises the block but doesn't call it yet unlike JRuby.
So because of this I haven't included test_feed specs in TestEnumerable (test:mri), as they fail because of the different order of evaluation of yield/method.
Though this PR does implement feed correctly for JRuby's next implementation, so I am raising it.