Conversation
mkristian
force-pushed
the
test-truffle-modular
branch
from
087d35a to
75a4913
Compare
|
+1 looks good to me. I'd say we also remove it from jruby-complete, since anyone using jruby-complete can just add jruby-truffle to deps and it will be there. |
|
This can merge now. |
|
yes. beside this some cleanup is needed - readline, ripper, back to but this can go in as is. On Wed, Jan 21, 2015 at 8:41 PM, Charles Oliver Nutter <
|
the source is split into core/src and truffle/src. some little code changes were needed to get it compliled. the lib/jruby.jar remains as is, dito jruby-complete.jar - just the way it gets build is slightly different. jruby-jars.gem has now three jars one is jruby-truffle.jar, so people want to use truffle need to require this jar as well. the jruby artifacts (org.jruby:jruby, org.jruby:jruby-noasm) can easily exclude truffle via :exclusions => ['org.jruby:jruby-truffle'] declaration.
* Removed truffle references from core/pom. * Moved over some files added after modularization PR.
headius
force-pushed
the
test-truffle-modular
branch
from
72c824d to
0dc42dc
Compare
|
I updated the patch and cleaned up some dependencies and force pushed to the PR branch. We need to fix -X+T at command line before we merge this, so truffle remains functional at command line. We can do that either in the launcher (requires jruby-launcher work in C/++) or shade it into lib/jruby.jar. |
|
shade it the truffle into lib/jruby.jar |
|
merged manually |
2 participants
this is a follow up of #2466 to propose a slightly different setup. it basically introduce a jruby-trufle artifact which can be easily exceluded using the jruby amven artifact. jruby-jars gem takes advantage of it as well, i.e. jruby-core jar there is already truffle free.