Conversation
…ader then ScriptingContainer does not work out of the box, dito with JRubyEngineFactory using a wrong value or 'none' value for the classloader system property (org.jruby.embed.classloader)
headius
added a commit
that referenced
this pull request
Nov 12, 2014
…sloader when jruby is not coming from the thread.currentThread.contextClassLoade...
Member
|
Bleh, so I misunderstood and tried to be proactive and merged this without realizing we needed some discussion. So back to the drawing board...this branch is NOT merged and we need to chat with @enebo. |
Member
|
Bleh...revert PR apparently doesn't re-open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...r then ScriptingContainer
does not work out of the box, dito with JRubyEngineFactory using a wrong value or 'none' value for the classloader
system property (org.jruby.embed.classloader)
@enebo as either this or the pull request: #2023
both have add some testcases. this one adds some cases where ScriptingContainer or JRubyScriptEngine fail to run ruby scripts. and with #2023 the tests show the opposite result. the intention is at least to test those "features" as expected behaviour.