Provide better error message when using :: in java_import (fixes #2074)#2075
Merged
headius merged 1 commit intojruby:masterfrom Nov 4, 2014
Merged
Provide better error message when using :: in java_import (fixes #2074)#2075headius merged 1 commit intojruby:masterfrom
headius merged 1 commit intojruby:masterfrom
Conversation
byteit101
force-pushed
the
master
branch
2 times, most recently
from
3b2a792 to
c79a062
Compare
Member
|
Did you see the failures? I think your patch is rejecting too much. |
Member
Author
|
Interesting. |
Member
|
The BSFException probably just wraps the same kind of exception as the ArgumentError. |
Member
|
Hmm yeah, I'm confused as well. |
headius
added a commit
that referenced
this pull request
Nov 2, 2014
Thanks to @byteit101 for the patch!
Member
|
Incorporated the other :: version manually so we at least error for that. If we can figure out this more comprehensive version, that would still be best. |
headius
added a commit
that referenced
this pull request
Nov 4, 2014
Provide better error message when using :: in java_import (fixes #2074)
yousuketto
pushed a commit
to yousuketto/jruby
that referenced
this pull request
Nov 22, 2014
Thanks to @byteit101 for the patch!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
raise an error with the wrong type of strings, as per irc:
I think it should be documented as saying this is Java calling format but we can probably look for ‘::’ in code and generate a better error message since I don’t think that is allowable in classname