Skip to content

Implemented multi args 'system' method on Windows fix #1074#2008

Merged
headius merged 1 commit intojruby:jruby-1_7from
yousuketto:internal_cmd_on_win
Nov 2, 2014
Merged

Implemented multi args 'system' method on Windows fix #1074#2008
headius merged 1 commit intojruby:jruby-1_7from
yousuketto:internal_cmd_on_win

Conversation

@yousuketto
Copy link
Contributor

@yousuketto yousuketto commented Sep 27, 2014

'system' method of multi args was not able to support Windows internal commands.
(ex) echo, cd, etc
fix #1074

jruby 1.7.16

# example.rb
p system("echo", "hoge")
p "----------"
p system("jruby", "-v")
c:\workspace\jruby1074>jruby example.rb
nil
"----------"
jruby 1.7.16 (1.9.3p392) 2014-09-25 575b395 on Java HotSpot(TM) 64-Bit Server VM 1.7.0_07-b11 +jit [Windows 7-amd64]
true

@yousuketto
Implemented multi args 'system' method on Windows
1355b9f 
'system' method of multi args was not able to support
Windows internal commands.
(ex) echo, cd, etc
@headius
Copy link
Member

headius commented Nov 2, 2014

Tests look ok and the change seems right. Can you help us a bit more by adding a regression spec to spec/regression? I will merge this.

headius added a commit that referenced this pull request Nov 2, 2014
@headius
Merge pull request #2008 from yousuketto/internal_cmd_on_win
581957e 
Implemented multi args 'system' method on Windows fix #1074
@headius headius merged commit 581957e into jruby:jruby-1_7 Nov 2, 2014
@headius headius added this to the JRuby 1.7.17 milestone Nov 2, 2014
@headius headius self-assigned this Nov 2, 2014
@headius headius mentioned this pull request Nov 2, 2014
Closed
yousuketto added a commit to yousuketto/jruby that referenced this pull request Nov 10, 2014
@yousuketto
add spec for jruby#2008
5545c12
@yousuketto yousuketto mentioned this pull request Nov 22, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@headius headius

Labels

core windows

Projects

None yet

Milestone

JRuby 1.7.17

Development

Successfully merging this pull request may close these issues.

2 participants

@yousuketto @headius