Skip to content

fix enums to return nil on unknown symbol#2003

Merged
headius merged 4 commits intojruby:jruby-1_7from
tduehr:enums_fix
Nov 2, 2014
Merged

fix enums to return nil on unknown symbol#2003
headius merged 4 commits intojruby:jruby-1_7from
tduehr:enums_fix

Conversation

@tduehr
Copy link
Contributor

@tduehr tduehr commented Sep 26, 2014

fixes #1954

tduehr added 3 commits October 6, 2014 13:30
updates variadic invoker to match MRI
variadic functions may now take enum arguments
also adds ffi spec for failure
@headius
Copy link
Member

headius commented Nov 2, 2014

There's a number of fixes here, but I'm willing to accept them as a batch since you pulled in updated FFI specs to confirm them.

headius added a commit that referenced this pull request Nov 2, 2014
fix enums to return nil on unknown symbol
@headius headius merged commit 8d12e83 into jruby:jruby-1_7 Nov 2, 2014
@headius headius added this to the JRuby 1.7.17 milestone Nov 2, 2014
@headius headius added the ffi label Nov 2, 2014
@headius headius self-assigned this Nov 2, 2014
@tduehr
Copy link
Contributor Author

tduehr commented Nov 3, 2014

I'd normally not do all this together but the functionality needed tests that weren't quite in the FFI suite here yet, so i went ahead and resynced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants