Skip to content

-X... and -X? options to search for properties.#1955

Merged
chrisseaton merged 1 commit intomasterfrom
search-options
Sep 9, 2014
Merged

-X... and -X? options to search for properties.#1955
chrisseaton merged 1 commit intomasterfrom
search-options

Conversation

@chrisseaton
Copy link
Contributor

I can never remember the names of various JRuby options - even my own! This allows you to search for them, either by prefix or substring. Are we interested in having this functionality?

Examples:

$ bin/jruby -Xdump?
compile.dump=false
jit.dumping=false
ffi.compile.dump=false
thread.dump.signal=USR2
dump.variables=false
$ bin/jruby -Xir...
ir.debug=false
ir.profile=false
ir.compiler.debug=false
ir.visualizer=false
ir.unboxing=false
ir.passes=null
ir.jit.passes=null
ir.reading=false
ir.reading.debug=false
ir.writing=false
ir.writing.debug=false
ir.inline_passes=null

I've modified the .sh and .bash launchers. Is there anything else I need to modify to pass these arguments through?

@mkristian
Copy link
Member

+1 would be used by me

@enebo
Copy link
Member

enebo commented Sep 7, 2014

+1 but someone needs to figure out if we need to change jruby-launcher gen for this and I am too busy with upcoming travel. Can someone run -Xtrace log.txt with this applied and make sure the last command passes these new syntaxes through properly?

@chrisseaton
Copy link
Contributor Author

I've updated jruby-launcher in jruby/jruby-launcher#8.

@headius
Copy link
Member

headius commented Sep 8, 2014

Is there a reason this is better than piping --properties to grep?

@chrisseaton
Copy link
Contributor Author

When I go to write a property I start writing -Xtruffle. and then pause as I realise I can't remember the name. So I'd have to erase all that and type --properties | grep truffle. Here as I realise I don't know the name, I just finish off with -Xtruffle... and press enter. I can then edit that line with the property I want as it's all already in place for me to finish.

It's a redundant UI adornment I know, but so is --profile.flat and --profile.

Edit: also, no grep on Windows.

@headius
Copy link
Member

headius commented Sep 9, 2014

No grep on Windows is the more compelling reason :-)

If nobody else objects I don't have a problem including this.

Will look at error.

@headius
Copy link
Member

headius commented Sep 9, 2014

Ignore the failure. It may be valid, but I restarted it to see if it goes away.

I'm going to have to investigate whether there's actually a problem, or if these are just bad specs. The threading specs have been notoriously bad.

Entirely unrelated to your stuff.

chrisseaton added a commit that referenced this pull request Sep 9, 2014
-X... and -X? options to search for properties.
@chrisseaton chrisseaton merged commit 65fd30c into master Sep 9, 2014
@chrisseaton chrisseaton deleted the search-options branch September 9, 2014 17:56
@chrisseaton chrisseaton modified the milestone: JRuby 9.0.0.0.rc1 May 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants